Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow headers pass through #89

Merged
merged 4 commits into from
Oct 24, 2023
Merged

feat: allow headers pass through #89

merged 4 commits into from
Oct 24, 2023

Conversation

gk-kindred
Copy link
Collaborator

  • Pass Candidate message headers to decision message for certifier.
  • Pass Decision message headers to on-commit publish messages in messenger.

@gk-kindred gk-kindred force-pushed the feature/certifier-decision-headers branch from 453eb2b to 042f54c Compare October 16, 2023 11:59
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (c76a702) 57.08% compared to head (1be6893) 57.36%.

❗ Current head 1be6893 differs from pull request most recent head 9926606. Consider uploading reports for the commit 9926606 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   57.08%   57.36%   +0.27%     
==========================================
  Files         115      115              
  Lines        5663     5747      +84     
==========================================
+ Hits         3233     3297      +64     
- Misses       2430     2450      +20
Files Coverage Δ
.../talos_certifier/src/services/certifier_service.rs 91.56% <100.00%> (+0.65%) ⬆️
..._certifier/src/services/decision_outbox_service.rs 89.74% <100.00%> (+1.33%) ⬆️
..._certifier/src/services/tests/certifier_service.rs 100.00% <100.00%> (ø)
...fier/src/services/tests/decision_outbox_service.rs 82.62% <100.00%> (+0.60%) ⬆️
...ckages/talos_certifier_adapters/src/kafka/utils.rs 78.46% <ø> (ø)
...ier/src/services/tests/message_receiver_service.rs 76.40% <96.77%> (+1.70%) ⬆️
packages/talos_messenger_core/src/core.rs 0.00% <0.00%> (ø)
...ges/talos_certifier_adapters/src/kafka/producer.rs 0.00% <0.00%> (ø)
...s_certifier_adapters/src/mock_certifier_service.rs 0.00% <0.00%> (ø)
...ages/talos_messenger_actions/src/kafka/producer.rs 0.00% <0.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fmarek-kindred
fmarek-kindred approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@fmarek-kindred fmarek-kindred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you notice any change in performance?

@gk-kindred
Copy link
Collaborator Author

@fmarek-kindred , I ran tests, and didn't notice any noticeable degradation in performance

@gk-kindred gk-kindred merged commit edda736 into master Oct 24, 2023
3 checks passed
@gk-kindred gk-kindred deleted the feature/certifier-decision-headers branch October 24, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarek-kindred fmarek-kindred fmarek-kindred approved these changes

@anil0906 anil0906 Awaiting requested review from anil0906

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gk-kindred @fmarek-kindred